Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dataLicense from CreationInfo #452

Merged
merged 2 commits into from
Dec 13, 2023
Merged

Remove dataLicense from CreationInfo #452

merged 2 commits into from
Dec 13, 2023

Conversation

goneall
Copy link
Member

@goneall goneall commented Jul 30, 2023

Resolves issue #341

@goneall goneall requested a review from swinslow July 30, 2023 01:36
@zvr
Copy link
Member

zvr commented Jul 30, 2023

Although I voted for this, we should wait for the resolution of spdx/change-proposal#8 before merging it.

@goneall
Copy link
Member Author

goneall commented Jul 30, 2023

Although I voted for this, we should wait for the resolution of spdx/change-proposal#8 before merging it.

Agree - I'll change this to draft.

Here's next steps copied from the meeting etherpad where this was discussed:

* Steve to upload minutes to meetings repo
* Steve to send details of current discussion and considered options to the mailing lists
* Jilayne to contact EU legal list for their input
* Timing: next release of SPDX spec will be in a week and a half, ideally would have this solution incorporated by then

@jlovejoy @swinslow - if you could update this issue once the decision is finalized.

@goneall goneall marked this pull request as draft July 30, 2023 22:23
Copy link
Member

@maxhbr maxhbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look fine.

@kestewart kestewart added Profile:Core Core Profile and related matters Profile:Licensing Licensing Profile and related matters labels Jul 31, 2023
@kestewart kestewart added this to the 3.0-rc2 milestone Jul 31, 2023
@swinslow
Copy link
Member

swinslow commented Aug 3, 2023

Thanks all. As mentioned in #341, consensus was not reached at the 2023-07-27 meeting about whether to (1) keep the field but broaden it to permit using any valid license expression, or (2) remove the field altogether. Links to the discussion and details are in #341.

Resolves issue #341

Signed-off-by: Gary O'Neall <gary@sourceauditor.com>
@goneall goneall marked this pull request as ready for review August 27, 2023 19:01
@goneall goneall marked this pull request as draft August 27, 2023 19:02
@maxhbr
Copy link
Member

maxhbr commented Sep 21, 2023

@swinslow : any updates here, was there further discussion?

@davaya
Copy link
Contributor

davaya commented Oct 17, 2023

PR #500 Payload.md mentions support for dataLicense at the physical document level.

Copy link
Member

@swinslow swinslow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 to remove dataLicense from CreationInfo, will follow up in change proposal thread regarding inclusion as an optional field in SpdxDocument

@goneall goneall marked this pull request as ready for review December 13, 2023 14:57
@goneall goneall merged commit a83d010 into main Dec 13, 2023
1 check passed
@goneall goneall deleted the issue341 branch December 13, 2023 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Profile:Core Core Profile and related matters Profile:Licensing Licensing Profile and related matters
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants